New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for multibyte encodings #89

Closed

enniel wants to merge 1 commit into thephpleague:master from enniel:multibyte

Contributor

enniel commented Aug 15, 2016 •

edited

Fix this #80 problem with multibyte encodings


          adding support for multibyte encodings

796cdad

enniel changed the title ~~adding support for multibyte encodings~~ Adding support for multibyte encodings

Member

duncan3dc commented Feb 10, 2018

Hi @enniel, thanks for your help.

There are a lot of changes here that don't really make sense, it looks like a find+replace approach without taking the context into consideration.

I've merged the changes that improve multibyte support (11beecf) and added some tests to ensure we don't see regressions in the future

duncan3dc closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment