Separate the test suites; tag legacy tests

thephpleague · Jul 19, 2020 · 27ecf75 · 27ecf75
1 parent 6e0c814
commit 27ecf75
Show file tree

Hide file tree

Showing 9 changed files with 57 additions and 4 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -10,8 +10,11 @@
          processIsolation="false"
          stopOnFailure="false">
     <testsuites>
-        <testsuite name="league/commonmark Test Suite">
-            <directory>tests</directory>
+        <testsuite name="league/commonmark Functional Tests">
+            <directory>tests/functional</directory>
+        </testsuite>
+        <testsuite name="league/commonmark Unit Tests">
+            <directory>tests/unit</directory>
         </testsuite>
     </testsuites>
     <filter>

diff --git a/src/Reference/Reference.php b/src/Reference/Reference.php
@@ -65,6 +65,7 @@ public function getTitle(): string
      * @return string
      *
      * @deprecated Use TextNormalizer::normalize() instead
+     * @group legacy
      */
     public static function normalizeReference(string $string): string
     {

diff --git a/tests/functional/Extension/HeadingPermalink/HeadingPermalinkExtensionTest.php b/tests/functional/Extension/HeadingPermalink/HeadingPermalinkExtensionTest.php
@@ -77,6 +77,9 @@ public function dataProviderForTestHeadingPermalinksWithCustomOptions()
         yield ["Test\n----", '<h2>Test<a id="custom-prefix-test" href="#test" name="test" class="custom-class" aria-hidden="true" title="Link">¶ 🦄️ &lt;3 You</a></h2>'];
     }
 
+    /**
+     * @group legacy
+     */
     public function testHeadingPermalinksWithDeprecatedInnerContents()
     {
         $environment = Environment::createCommonMarkEnvironment();

diff --git a/tests/unit/ConverterTest.php b/tests/unit/ConverterTest.php
@@ -17,6 +17,9 @@
 use League\CommonMark\Converter;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @group legacy
+ */
 class ConverterTest extends TestCase
 {
     public function testInvokeReturnsSameOutputAsConvertToHtml()

diff --git a/tests/unit/Extension/Autolink/InlineMentionParserTest.php b/tests/unit/Extension/Autolink/InlineMentionParserTest.php
@@ -18,6 +18,8 @@
 
 /**
  * @deprecated
+ *
+ * @group legacy
  */
 final class InlineMentionParserTest extends TestCase
 {

diff --git a/tests/unit/Extension/HeadingPermalink/Slug/DefaultSlugGeneratorTest.php b/tests/unit/Extension/HeadingPermalink/Slug/DefaultSlugGeneratorTest.php
@@ -16,6 +16,8 @@
 
 /**
  * @deprecated
+ *
+ * @group legacy
  */
 final class DefaultSlugGeneratorTest extends TestCase
 {

diff --git a/tests/unit/Extension/TableOfContents/TableOfContentsDeprecationTest.php b/tests/unit/Extension/TableOfContents/TableOfContentsDeprecationTest.php
@@ -16,6 +16,9 @@
 use League\CommonMark\Extension\TableOfContents\TableOfContents as DeprecatedTableOfContents;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @group legacy
+ */
 final class TableOfContentsDeprecationTest extends TestCase
 {
     /**

diff --git a/tests/unit/Util/ArrayCollectionTest.php b/tests/unit/Util/ArrayCollectionTest.php
@@ -52,6 +52,9 @@ public function testGetIterator()
         $this->assertEquals($array, $iterator->getArrayCopy());
     }
 
+    /**
+     * @group legacy
+     */
     public function testAdd()
     {
         $collection = new ArrayCollection();
@@ -64,6 +67,9 @@ public function testAdd()
         $this->assertEquals(['foo', 'bar'], $collection->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testSet()
     {
         $collection = new ArrayCollection(['foo']);
@@ -76,6 +82,9 @@ public function testSet()
         $this->assertEquals(['foo', 'foo' => 2], $collection->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testGet()
     {
         $collection = new ArrayCollection(['foo' => 1, 'bar']);
@@ -85,6 +94,9 @@ public function testGet()
         $this->assertNull($collection->get('bar'));
     }
 
+    /**
+     * @group legacy
+     */
     public function testRemove()
     {
         $collection = new ArrayCollection(['foo' => 1, 'bar', 'baz']);
@@ -106,6 +118,9 @@ public function testRemove()
         $this->assertEquals([], $collection->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testRemoveNulls()
     {
         $collection = new ArrayCollection(['foo' => null]);
@@ -119,6 +134,9 @@ public function testRemoveNulls()
         $this->assertEquals([], $collection->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testIsEmpty()
     {
         $collection = new ArrayCollection();
@@ -135,6 +153,9 @@ public function testIsEmpty()
         $this->assertFalse($collection->isEmpty());
     }
 
+    /**
+     * @group legacy
+     */
     public function testContains()
     {
         $object = new \stdClass();
@@ -155,6 +176,9 @@ public function testContains()
         $this->assertFalse($collection->contains('FOO'));
     }
 
+    /**
+     * @group legacy
+     */
     public function testIndexOf()
     {
         $object = new \stdClass();
@@ -175,6 +199,9 @@ public function testIndexOf()
         $this->assertTrue(false === $collection->indexOf('FOO'));
     }
 
+    /**
+     * @group legacy
+     */
     public function testContainsKey()
     {
         $collection = new ArrayCollection(['foo' => 1, 'bar']);
@@ -197,10 +224,10 @@ public function testCount()
         $collection = new ArrayCollection(['foo']);
         $this->assertEquals(1, $collection->count());
 
-        $collection->add('bar');
+        $collection[] = 'bar';
         $this->assertEquals(2, $collection->count());
 
-        $collection->remove(0);
+        unset($collection[0]);
         $this->assertEquals(1, $collection->count());
     }
 
@@ -320,6 +347,9 @@ public function testToArray()
         $this->assertEquals([2 => 1, 'foo'], $collection->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testReplaceWith()
     {
         $collection = new ArrayCollection(['foo' => 1, 'bar']);
@@ -330,6 +360,9 @@ public function testReplaceWith()
         $this->assertEquals(['baz', 42], $replaced->toArray());
     }
 
+    /**
+     * @group legacy
+     */
     public function testRemoveGaps()
     {
         $collection = new ArrayCollection(['', true, false, null, [], 0, '0', 1]);

diff --git a/tests/unit/Util/Html5EntitiesTest.php b/tests/unit/Util/Html5EntitiesTest.php
@@ -5,6 +5,9 @@
 use League\CommonMark\Util\Html5Entities;
 use PHPUnit\Framework\TestCase;
 
+/**
+ * @group legacy
+ */
 class Html5EntitiesTest extends TestCase
 {
     public function testEntityToChar()