Skip to content

Commit

Permalink
Move BC check to separate workflow; run against PR base
Browse files Browse the repository at this point in the history
  • Loading branch information
colinodell committed Feb 13, 2022
1 parent e0feba0 commit 34712ca
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 8 deletions.
21 changes: 21 additions & 0 deletions .github/workflows/backwards-compatibility.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: "Backwards compatibility"

on:
pull_request:

jobs:
bc-check:
name: "Backwards compatibility check"

runs-on: "ubuntu-latest"

steps:
- name: "Checkout"
uses: "actions/checkout@v2.4.0"
with:
fetch-depth: 0

- name: "BC Check"
uses: docker://nyholm/roave-bc-check-ga
with:
args: --from=${{ github.event.pull_request.base.sha }}
8 changes: 0 additions & 8 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,6 @@ jobs:

- run: vendor/bin/psalm --no-progress --stats --threads=$(nproc) --output-format=github --shepherd

bc_check:
name: Backward Compatibility
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Roave BC Check
uses: docker://nyholm/roave-bc-check-ga

docs-lint:
name: Markdownlint
runs-on: ubuntu-latest
Expand Down

0 comments on commit 34712ca

Please sign in to comment.