Fix str_replace not targeting the right array element

thephpleague · Feb 2, 2024 · 7497619 · 7497619
1 parent 035aea8
commit 7497619
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/tests/functional/CMarkRegressionTest.php b/tests/functional/CMarkRegressionTest.php
@@ -30,10 +30,10 @@ public static function dataProvider(): \Generator
             // We can't currently render spec example 13 exactly how the upstream library does. We'll likely need to overhaul
             // our rendering approach in order to fix that, so we'll use this temporary workaround for now.
             if ($example['number'] === 13) {
-                yield \str_replace('</script></li>', "</script>\n</li>", $example);
-            } else {
-                yield $example;
+                $example['output'] = \str_replace('</script></li>', "</script>\n</li>", $example['output']);
             }
+
+            yield $example;
         }
     }
 }
diff --git a/tests/functional/CommonMarkJSRegressionTest.php b/tests/functional/CommonMarkJSRegressionTest.php
@@ -30,10 +30,10 @@ public static function dataProvider(): \Generator
             // We can't currently render spec example 18 exactly how the upstream library does. We'll likely need to overhaul
             // our rendering approach in order to fix that, so we'll use this temporary workaround for now.
             if ($example['number'] === 18) {
-                yield \str_replace('</script></li>', "</script>\n</li>", $example);
-            } else {
-                yield $example;
+                $example['output'] = \str_replace('</script></li>', "</script>\n</li>", $example['output']);
             }
+
+            yield $example;
         }
     }
 }