Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter coding standard #435

Closed
colinodell opened this issue Apr 12, 2020 · 2 comments
Closed

Stricter coding standard #435

colinodell opened this issue Apr 12, 2020 · 2 comments
Assignees
@colinodell
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior implemented Change has been implemented
Milestone
v2.0

Comments

@colinodell
Copy link
Member

While I do love StyleCI and hope to keep it, I'd like to augment that with something a little stricter and PHPCS-based.
@colinodell colinodell added enhancement New functionality or behavior do not close Issue which won't close due to inactivity labels Apr 12, 2020
@colinodell colinodell added this to the v1.4.0 milestone Apr 12, 2020
@colinodell colinodell self-assigned this Apr 12, 2020
@GrahamCampbell
Copy link
Member

You can always enable more rules on StyleCI, and if there's something missing you'd like to see, it could be implemented. :)

@colinodell colinodell modified the milestones: v1.4.0, v2.0 Apr 18, 2020
colinodell added a commit that referenced this issue May 9, 2020
@colinodell
Apply stricter coding standard (#435)
6ac414f
@colinodell colinodell mentioned this issue May 9, 2020
Merged
colinodell added a commit that referenced this issue May 9, 2020
@colinodell
Apply stricter coding standard (#435)
f58cca0
colinodell added a commit that referenced this issue May 9, 2020
@colinodell
Apply stricter coding standard (#435)
0de0ea4
@colinodell
Copy link
Member Author

I'm going to temporarily set StyleCI to use psr1 because I don't know how to configure it to match the new PHPCS code style I want to use (largely based on Doctrine's): https://github.styleci.io/analyses/D2Wvdn

@close-label close-label bot added the implemented Change has been implemented label May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinodell colinodell

Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior implemented Change has been implemented
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@colinodell @GrahamCampbell