Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 deprecated warning #762

Merged
merged 2 commits into from
Dec 5, 2021
Merged

PHP 8.1 deprecated warning #762

merged 2 commits into from
Dec 5, 2021

Conversation

ElGigi
Copy link
Contributor

@ElGigi ElGigi commented Dec 3, 2021

Prevent deprecated warning on ArrayAccess with PHP 8.1

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the annotation on offsetGet is needed.

src/Util/ArrayCollection.php Outdated Show resolved Hide resolved
src/Util/ArrayCollection.php Outdated Show resolved Hide resolved
src/Util/ArrayCollection.php Outdated Show resolved Hide resolved
@ElGigi
Copy link
Contributor Author

ElGigi commented Dec 3, 2021

Sorry, changed! A little too fast in my modification.

Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colinodell colinodell merged commit c7fc28c into thephpleague:main Dec 5, 2021
@colinodell colinodell linked an issue Dec 5, 2021 that may be closed by this pull request
@colinodell colinodell mentioned this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.1 Support
3 participants