Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded phpunit-mock-objects version requirements #89

Closed
colinodell opened this issue Apr 14, 2015 · 2 comments
Closed

Remove hard-coded phpunit-mock-objects version requirements #89

colinodell opened this issue Apr 14, 2015 · 2 comments
Assignees
@colinodell
Labels
good first issue An easy issue for new collaborators on hold We're not quite ready for this yet

Comments

@colinodell
Copy link
Member

We're currently requiring version 2.3.0 because 2.3.1 uses a broken reflection implementation in HHVM which causes our tests to fail. Once HHVM fixes this issue I'd like to revert commit 2a6a97c so we're using the latest and greatest version again.
@colinodell colinodell added the good first issue An easy issue for new collaborators label Apr 14, 2015
@colinodell colinodell self-assigned this Apr 14, 2015
@colinodell colinodell added the on hold We're not quite ready for this yet label Apr 14, 2015
@colinodell colinodell mentioned this issue Apr 28, 2015
Merged
colinodell added a commit that referenced this issue Jun 8, 2015
@colinodell
Undo temporary hardcoding of dev dependency (#89)
9803bbf
@colinodell colinodell removed the on hold We're not quite ready for this yet label Jun 8, 2015
@colinodell colinodell added this to the Version 0.9 milestone Jun 8, 2015
@colinodell
Copy link
Member Author

Huh, looks like Travis isn't using the new HHVM build yet. Will put this back on hold until HHVM 3.5.0 is upgraded.

@colinodell colinodell removed this from the Version 0.9 milestone Jun 8, 2015
@colinodell colinodell added the on hold We're not quite ready for this yet label Jun 8, 2015
@colinodell
Copy link
Member Author

It looks like the fix landed in HHVM 3.8.0 but Travis is still using 3.5.0. facebook/hhvm@b786320

@postalservice14 postalservice14 mentioned this issue Oct 19, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinodell colinodell

Labels
good first issue An easy issue for new collaborators on hold We're not quite ready for this yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinodell