Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated styleci config #151

Merged
merged 1 commit into from Jul 19, 2015
Merged

Updated styleci config #151

merged 1 commit into from Jul 19, 2015

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@GrahamCampbell
Copy link
Member Author

Our recommended fixer set is very similar to symfony, only actually matches what you wanted better.

@GrahamCampbell
Copy link
Member Author

There are a few places where you've put return null; at the end of a function. You should actually delete those statements entirely since they do absolutely nothing. Both the symfony and recommended reset fixed those to return;.

@colinodell
Copy link
Member

Thanks, I'll give this a try!

colinodell added a commit that referenced this pull request Jul 19, 2015
@colinodell
Merge pull request #151 from GrahamForks/styleci
2bc76b6 
Updated styleci config
@colinodell colinodell merged commit 2bc76b6 into thephpleague:master Jul 19, 2015
@GrahamCampbell GrahamCampbell deleted the styleci branch July 19, 2015 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @colinodell