Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: add recommendation to html sanitizing #355

Closed
wants to merge 1 commit into from
Closed

security: add recommendation to html sanitizing #355

wants to merge 1 commit into from

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Apr 1, 2019

you recommended some library to sanitize html using whitelisted tags, attributes.

but i can't find what you recommended, or where...

@colinodell colinodell closed this in 9e03020 Apr 9, 2019
@colinodell
Copy link
Member

Implemented via 9e03020

@glensc
Copy link
Contributor Author

glensc commented Apr 9, 2019

btw, htmlpurifier is not good. it seems old, it can't parse html5. for example i tried to make it whitelist <details> tag, and even with very complex code to do so, i still failed to achieve that. also could not find a way to preserve html comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glensc @colinodell