Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2.0 mention docs to use pattern instead of regex #574

Merged
merged 2 commits into from Oct 10, 2020
Merged

Fix 2.0 mention docs to use pattern instead of regex #574

merged 2 commits into from Oct 10, 2020

Conversation

markhalliwell
Copy link
Contributor

Oops, we missed this

@markhalliwell
Fix 2.0 mention docs to use pattern instead of regex
651a44d 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell markhalliwell added this to the v2.0 milestone Oct 10, 2020
@markhalliwell markhalliwell added the documentation Documentation issues or updates label Oct 10, 2020
@markhalliwell
Fix the note about how multiple mention symbols actually work
7188b91 
Signed-off-by: Mark Carver <mark.carver@me.com>
colinodell
colinodell approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! There are too many docs to keep track of 🙃

@colinodell colinodell merged commit 53a2f2a into thephpleague:latest Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinodell colinodell colinodell approved these changes

Assignees
No one assigned
Labels
documentation Documentation issues or updates
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markhalliwell @colinodell