Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPStan failures #24

Merged
merged 4 commits into from Oct 5, 2023
Merged

Fix PHPStan failures #24

merged 4 commits into from Oct 5, 2023

Commits on Oct 5, 2023

  1. Fix PHPStan failures 

    Errors:

PHPStan: src/Configuration.php#L120 Dead catch - Dflydev\DotAccessData\Exception\MissingPathException is never thrown in the try block.

PHPStan: src/Configuration.php#L193 Parameter 1 $data of method Dflydev\DotAccessData\Data::import() expects array<string, mixed>, array given.
    @praem90
    praem90 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4ffb0cd View commit details
    Browse the repository at this point in the history

  2. Only handle known exceptions

    @colinodell
    colinodell committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ea0efb5 View commit details
    Browse the repository at this point in the history

  3. Use assert() instead

    @colinodell
    colinodell committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    25fc7bb View commit details
    Browse the repository at this point in the history

  4. Remove redundant cast

    @colinodell
    colinodell committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a0821f6 View commit details
    Browse the repository at this point in the history