Fixed issue where all service providers were registered regardless of…

… whether they need to be
thephpleague · Sep 21, 2018 · a6c52d7 · a6c52d7
1 parent 4264532
commit a6c52d7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All Notable changes to `League\Container` will be documented in this file
 
+## 3.2.1
+
+### Fixed
+- Fixed issue where all service providers were registered regardless of whether they need to be.
+
 ## 3.2.0
 
 ### Added

diff --git a/src/ServiceProvider/ServiceProviderAggregate.php b/src/ServiceProvider/ServiceProviderAggregate.php
@@ -93,9 +93,10 @@ public function register(string $service)
                 return;
             }
 
-            $provider->register();
-
-            $this->registered[] = $provider->getIdentifier();
+            if ($provider->provides($service)) {
+                $provider->register();
+                $this->registered[] = $provider->getIdentifier();
+            }
         }
     }
 }