Fix stack overflow error incase a service provider lies about providing a specific service #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case a service provider returns true when
provides(string $service): boolis called, but doesn't actually provide it, a stack overflow will occur (->get()calls->get()over and over again ) resulting in a fatal error. throwing an exception in this case is better.i have faced this issue while working in
nuxed/container( since the container package is a re-implementation of the league container in hack lang ) ( see : nuxed/framework@4f693ab )( i accidentally deleted the fork for #168 )