Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Multiple filter conditions #11

Closed
nyamsprod opened this issue Feb 21, 2014 · 0 comments
Closed

Adding Multiple filter conditions #11

nyamsprod opened this issue Feb 21, 2014 · 0 comments
Labels
enhancement

Comments

@nyamsprod
Copy link
Member

The IteratorQuery trait enable filtering the CSV. But as of now you can only set one filter by query. So if you want to make a complex filtering condition you have to register a very complex function.

It would be interesting to be able to set as many filtering conditions as we want. So that the user can register small yet more readable filters ?

If we register multiple filter:

  • should the registration order matter ?
  • should we be able to register/unregistered the filters ?
nyamsprod added a commit that referenced this issue Mar 6, 2014
@nyamsprod
you can add/remove multiple filter
9d376cd 
Improve IteratorFilter::applyFilter method #11
nyamsprod added a commit that referenced this issue Mar 7, 2014
@nyamsprod
you can add/remove multiple filter
73448a4 
Improve IteratorFilter::applyFilter method #11
nyamsprod added a commit that referenced this issue Mar 10, 2014
@nyamsprod
you can add/remove multiple filter
5a5200f 
Improve IteratorFilter::applyFilter method #11
@nyamsprod nyamsprod mentioned this issue Mar 10, 2014
Merged
@thephpleague thephpleague locked and limited conversation to collaborators Jan 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyamsprod