Adding the ability to control skipping empty records by the Reader class #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clcastro87 this PR was prompted by your issue it adds the ability to also control if empty records should be skipped or not. If you could test it and tell me if that's also good for you. Again I should stress that those features will only be release end of september at least. |
nyamsprod
changed the title
nyamsprod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability in the Reader class to control if empty records should be skipped or not. By default and to avoid BC break empty records are skipped. The result of
Reader::getRecordswill be controlled by the following methods.Reader::preserveEmptyRecordReader::skipEmptyRecordReader::isEmptyRecordSkipped