Ditch EventInterface

[jenkoian]

I like to wrap dependencies in my own interfaces and use adapters so as not to be too coupled to a library, useful if, for example, I want to change from one library to another. I could do this with this library too, except for events as they rely on implementing EventInterface, thus meaning my event classes are coupled to this library.

So I was wondering if you'd consider ditching the interfaces on events? I guess the interface is useful to ensure the presence of a getName() method but wondering if we could get around that by a method exists check, perhaps falling back to the class name?

I can PR this if you are happy to do so. Tactician took a similar approach for commands a while ago too if it helps to understand the issue I'm likely horribly trying to describe thephpleague/tactician#43.

I'd understand if you want to keep the interface, but am interested in your thoughts none the less :)

[Zegnat]

I’m not sure if this makes sense considering #70. Or at least I would say a choice needs to be made between either dropping interfaces or standardising against the proposed Event Manager standard and taking their interfaces.

[frankdejonge]

@jenkoian I'm in favour of this. Sometimes when I feel like it I rewrite these packages and in many of the event implementation I've done besides this I've removed the need for an event interface. I'm thinking of pivotting this more into an domain event lib, though I also know there's a need for a more framework-ish event lib. Perhaps it can provide both, perhaps they can be two separate packages, I'm not sure yet. I'm open to suggestions.

[frankdejonge]

Ok, so I make a PR for this #84

[binary-data]

Hi, any update on this?

Static analyzers like PHPStan produce "Call to an undefined method" warnings on custom event class methods and clutter the output.

    public function handle(EventInterface $event): void
    {
        // Call to an undefined method warning here
        $event->getValue();
       ...
    }

Type annotations are helpful for IDE but static analyzers treat them differently.

It would be nice to provide my own class annotation so IDE and other tools see methods correctly.

[frankdejonge]

Version 3 (released soon) has no event interface.