Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offical Website #67

Closed
philsturgeon opened this issue Jul 15, 2014 · 97 comments
Closed

Offical Website #67

philsturgeon opened this issue Jul 15, 2014 · 97 comments
Assignees
Milestone

Comments

@philsturgeon
Copy link
Member

Who wants the job of making the documentation for the website?

Instructions here

@scottrobertson
Copy link
Contributor

Once we decide on and implement #66 I shall do it.

@scottrobertson scottrobertson modified the milestones: v2.0, v2.0.0, v2.0RC1 Jul 15, 2014
@scottrobertson
Copy link
Contributor

Why can't we just use Jekyll :( all this coping folders around and stuff is awful.

@scottrobertson
Copy link
Contributor

Also, Sculpin does not work. When i generate, all of the *.html files are totally empty.

@philsturgeon
Copy link
Member Author

It sounds to me like you are doing it wrong. Hop on IRC sometime and lets see if you can get some help from @reinink.

It's a nice smooth process as far as I'm concerned. :)

@scottrobertson
Copy link
Contributor

Regarding my first message, its to do with https://github.com/thephpleague/thephpleague.github.com/tree/project-website-theme#how-to-publish (awful)

Second part, I am just running sculpin generate and all the files are there, but empty.

@philsturgeon
Copy link
Member Author

That is literally one piece of setup with a bit of advice on a good way to do things. Sculpin is basically missing a rake deploy equivalent and you need to do that yourself, but of course as we are smart budding developers we can do that sort of thing ourselves.

https://github.com/thephpleague/fractal/blob/sculpin/deploy.sh

Identical to rake deploy. I just enter my github credentials after its built and the job is done. 

Copy that, tweak it as you need and I’ll update the how to page.

@scottrobertson
Copy link
Contributor

Ok, thanks.

I just prefer being able to just push 'gh-pages' repo and it just builds it all it's self haha.

@reinink
Copy link

reinink commented Jul 30, 2014

I can appreciate that the publishing process feels a little painful. What you see in those instructions is the simplest possible instructions I could come up with, other than actually creating a deploy script as Phil is suggesting. We decided to use Sculpin because, 1. it's a PHP project, and 2. it supports themes.

@reinink
Copy link

reinink commented Jul 30, 2014

Also, Sculpin does not work. When i generate, all of the *.html files are totally empty.

That clearly is not right. I wonder if there have potentially been some updates to Sculpin that are breaking things. I'm going to have to do some testing to confirm.

@scottrobertson
Copy link
Contributor

I can appreciate that the publishing process feels a little painful. What you see in those instructions is the simplest possible instructions I could come up with, other than actually creating a deploy script as Phil is suggesting. We decided to use Sculpin because, 1. it's a PHP project, and 2. it supports themes.

Makes total sense

That clearly is not right. I wonder if there have potentially been some updates to Sculpin that are breaking things. I'm going to have to do some testing to confirm.

Thank you. I shall try remove and install it all again when i get home. I was going to try a different php version etc too just to make sure.

@reinink
Copy link

reinink commented Jul 30, 2014

Okay, so I was able to reproduce the blank pages when I did not run sculpin install prior to starting the server (sculpin generate --watch --server). Can you confirm that you've run this?

You can tell if sculpin install has been run if there is a .sculpin folder. There will also be a /source/themes/ folder created.

@GrahamCampbell
Copy link
Member

I've generated some api docs here: http://muffin.grahamjcampbell.co.uk/.
I've included the faker library in the generation. Also, I've excluded all the tests.

What do you guys think? Also, sami isn't generating the @method docs correctly? Can anybody confirm that the static @method docs work for them in their ide?

@scottrobertson
Copy link
Contributor

Can you confirm that you've run this?

@reinink I did yeah. I shall check if folder exists when I get back home.

I've included the faker library in the generation. Also, I've excluded all the tests.

@GrahamCampbell I am not sure we need to include their stuff do we?

@GrahamCampbell
Copy link
Member

We don't have to, no. I can remove it if you like?

@scottrobertson
Copy link
Contributor

That is totally up to you :) it was just my opinion.

@GrahamCampbell
Copy link
Member

I'll ditch them. It's way faster to generate without them. :)

@GrahamCampbell
Copy link
Member

http://muffin.grahamjcampbell.co.uk/

You might need to hit crtl + f5 to see the changes.

@GrahamCampbell
Copy link
Member

What do you want to do about these api docs?

@scottrobertson
Copy link
Contributor

I could have a go sometime, but I am not going to have time tonight/tomorrow.

@GrahamCampbell
Copy link
Member

I was asking about the "api docs". As in, those auto-generated ones.

@GrahamCampbell
Copy link
Member

Do we want to make the offical, maybe change the url?

@scottrobertson
Copy link
Contributor

Ohh right ok. I'm not sure what we should do with them. Not sure what the process around hosting them is etc.

@GrahamCampbell
Copy link
Member

Well, we could use github pages, or just leave them on my droplet. I can't imagine them using much resources.

@scottrobertson
Copy link
Contributor

Not sure how we could use github pages, as gh-pages branch will be used by the docs

@GrahamCampbell
Copy link
Member

We could make a new repo anywhere. Github pages allows custom urls.

@scottrobertson
Copy link
Contributor

Yeah i was going to say that, do we NEED an author? Can we not make it optional?

@reinink
Copy link

reinink commented Aug 11, 2014

I think for consistency it would be nice to have. As in, I wouldn't remove it just because there are two project leads.

@GrahamCampbell
Copy link
Member

Can you just write something. It's not worth the discussion, as long as the package is added.

@scottrobertson
Copy link
Contributor

@GrahamCampbell I think we need to submit a PR

@reinink
Copy link

reinink commented Aug 11, 2014

@scottrobertson Yep, if you need me to do it let me know.

@GrahamCampbell
Copy link
Member

@reinink That might be easier if you could.

@reinink
Copy link

reinink commented Aug 11, 2014

On it.

@scottrobertson
Copy link
Contributor

Thank you @reinink

@GrahamCampbell GrahamCampbell changed the title [2.1] Offical Website Offical Website Aug 11, 2014
@GrahamCampbell
Copy link
Member

It seems to be working now: http://factory-muffin.thephpleague.com/. I've put the api docs on there too.

@GrahamCampbell
Copy link
Member

@scottrobertson If you don't have time, I can sort the sculpin website tomorrow.

@GrahamCampbell
Copy link
Member

I'm working on this now.

@scottrobertson
Copy link
Contributor

Thanks. Sorry i missed your comment last night.

@GrahamCampbell
Copy link
Member

Done: http://factory-muffin.thephpleague.com/. You may need to ctrl+f5 to see the new site or whatever.

@scottrobertson
Copy link
Contributor

Awesome, thank you @GrahamCampbell

@GrahamCampbell
Copy link
Member

@reinink Sculpin isn't rendering bullet points correctly:
http://factory-muffin.thephpleague.com/usage/more/

@reinink
Copy link

reinink commented Aug 13, 2014

@GrahamCampbell You just needed an extra line return. I've added this, but you still need to republish.

@GrahamCampbell
Copy link
Member

Ok. There are probably a few other occurrences I'll need to find. I'll republish the site later today. There are a few other things I need to fix.

@scottrobertson
Copy link
Contributor

Thanks @reinink

@reinink
Copy link

reinink commented Aug 13, 2014

Happy to help gents. I've also added Google Analytics and fixed your permalinks.

@GrahamCampbell
Copy link
Member

Thanks. Also, how do we access the analytic data? Can it be read-only shared with our google accounts?

@reinink
Copy link

reinink commented Aug 13, 2014

For sure, just provide me with your Google account email address.

@GrahamCampbell
Copy link
Member

I'll email them to you...

@scottrobertson
Copy link
Contributor

Mine is added :)

@GrahamCampbell
Copy link
Member

I've just regenerated the website now.

@scottrobertson
Copy link
Contributor

awesome, looks good :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants