Added An Upgrade Guide And Better Usage Docs #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
@scottrobertson I'd say I'm pretty much done writing it now. You can see the full file in all it's glory here: https://github.com/GrahamCampbell/factory-muffin/blob/upgrading/UPGRADING.md. What do you think? |
|
I am on my phone out of the house so I can't really get into it fully. It looks awesome though. There are back few cases where you are using Factory directly instead of the Facade. |
GrahamCampbell
changed the title
|
@scottrobertson Fixed, and I've added more usage docs to the readme too. You can see the readme here: https://github.com/GrahamCampbell/factory-muffin/tree/upgrading. |
Closed
|
@scottrobertson Are you able to take a look at this today? |
|
This all looks awesome :) it all good to merge? |
scottrobertson
added a commit
that referenced
this pull request
Aug 3, 2014
Added An Upgrade Guide And Better Usage Docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #67 and #186.