Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose instance level define through facade. #90

Merged
merged 1 commit into from
Jul 21, 2014

Conversation

ianterrell
Copy link

[Fixes #66]

@scottrobertson
Copy link
Contributor

ahh cool, I forgot about about doing it in the Facade.

Shall get this merged and then will look at updating readme.

@scottrobertson
Copy link
Contributor

Missing ; on line 74

@ianterrell
Copy link
Author

Fixed with a forced update. Looks like CI is running again.

Guess I'm showing my Ruby roots. :)

@scottrobertson
Copy link
Contributor

:P i keep doing it too, ; is awful :P.

I am going to merge this, but it requires a bit more work before it will work. Shall do that now.

@scottrobertson
Copy link
Contributor

Or not, i got it working without changes :D updating docs etc now.

@philsturgeon @FrenkyNet @GrahamCampbell we need to decide if we want to remove the option of defining static $factory or factory(). I kind of want to get rid of it, but maybe not in this version.

scottrobertson added a commit that referenced this pull request Jul 21, 2014
Expose instance level define through facade.
@scottrobertson scottrobertson merged commit b19e04e into thephpleague:master Jul 21, 2014
@GrahamCampbell GrahamCampbell added this to the v2.0.0-RC1 milestone Aug 3, 2014
@GrahamCampbell GrahamCampbell modified the milestones: v2.0.0, v2.0.0-RC1 Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove FactoryMuffin from Models
3 participants