Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed listing of the existing directory in Ftpd #1047

Conversation

SilverFire
Copy link

Follows the parent class fix 5901bb5
Before the change, calling getMetadata() over an existing directory produced a fatal error.

PHP Fatal error:  Uncaught RuntimeException: Metadata can't be parsed from item 'total 334920' , not enough parts. in /app/vendor/league/flysystem/src/Adapter/AbstractFtpAdapter.php:435

Ftpd produces the following output on STAT call over directory:

array(46) {
  [0]=>
  string(32) "212- Status of content10/export:"
  [1]=>
  string(12) "total 334920"
  [2]=>
  string(72) "-rw-r--r--  1 1000  1000   3645884 Jul 18 06:10 movie.ts"
  
  [....]

  [45]=>
  string(18) "212 End of status."
}

Then, it can not be parsed by normalizeObject

@SilverFire
Copy link
Author

Ok, I see the tests fail. Will check details later

@SilverFire SilverFire changed the title Fixed listing of the existing directory in Ftpd [WIP] Fixed listing of the existing directory in Ftpd Jul 18, 2019
@SilverFire SilverFire force-pushed the fix/ftpd-existing-directory-listing branch from 797a15b to df63a27 Compare August 11, 2019 09:20
Follows the parent class fix 5901bb5
Before the change, calling getMetadata() over an existing directory produced a fatal error.
@SilverFire SilverFire force-pushed the fix/ftpd-existing-directory-listing branch from df63a27 to 3e37c0b Compare August 11, 2019 09:52
@SilverFire SilverFire changed the title [WIP] Fixed listing of the existing directory in Ftpd Fixed listing of the existing directory in Ftpd Aug 11, 2019
@SilverFire
Copy link
Author

Fixed tests, ready for review

@frankdejonge frankdejonge merged commit 3e37c0b into thephpleague:master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants