Implemented HttpAdapter with guzzle #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang. This needs rebasing again... |
Signed-off-by: Graham Campbell <graham@mineuk.com>
|
@FrenkyNet Is this good to go then? You said on the original pull you'd be happy to merge it an tweak it yourself after it was rebased, and here it is rebased, and I've added readme docs. :) |
|
@GrahamCampbell do you know if it's possible to create a PR for a feature branch? This way I can work on it before merging it into master. |
|
@FrenkyNet you can just open a PR against |
|
If you like, you could always merge my pull request yourself using git to another branch on your repo? Or as @staabm said, you can always send pull requests to my fork. |
|
Merged this into a feature branch. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #178.