This repository has been archived by the owner on May 12, 2018. It is now read-only.
Performance improvements #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-allan
force-pushed
the
perf-hacks
branch
4 times, most recently
from
990126a
to
df19a12
Compare
added 2 commits
June 2, 2017 10:28
- Prevent internal try/catch when pointers reference non-existent values. - Remove unnecessary strpos, array_map, and str_replace calls when parsing pointers. - Resolve JSON Schema scope without using pointers at all. - Replace recursion and array_shift with foreach when traversing pointers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran some tests with blackfire because dereferencing the swagger schema seemed slow. Apparently the JSON Schema scope resolver is the bottleneck.
To resolve the Swagger schema we have to call Pointer::get 1104 times. First I optimized the pointer, but then I realized we can cut the pointer usage out of that function completely.