Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Guzzle 7 too #101

Closed
wants to merge 1 commit into from
Closed

Allow Guzzle 7 too #101

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jul 2, 2020

TODO:

  • Update composer
  • Read source code to understand Guzzle usage
  • Update source code
  • Confirm tests pass on both Guzzle versions

@GrahamCampbell
Copy link
Member Author

NB It doesn't look like the current travis config works. HHVM is testing HHVM 4 instead of 3, and there's no PHP 7.1+ runs.

@shehi
Copy link

shehi commented Aug 20, 2020

@GrahamCampbell , travis.yml for you, if you wanna play with it:

language: php

before_script:
  - travis_retry composer self-update
  - travis_retry composer global require hirak/prestissimo
  - travis_retry composer install --no-interaction --prefer-source --dev
  - travis_retry phpenv rehash

script:
  - ./vendor/bin/phpcs --standard=psr2 src/
  - ./vendor/bin/phpunit --coverage-text --coverage-clover=coverage.clover

after_script:
  - if [ "$TRAVIS_PHP_VERSION" != "hhvm" ] && [ "$TRAVIS_PHP_VERSION" != "7.0" ]; then wget https://scrutinizer-ci.com/ocular.phar; fi
  - if [ "$TRAVIS_PHP_VERSION" != "hhvm" ] && [ "$TRAVIS_PHP_VERSION" != "7.0" ]; then php ocular.phar code-coverage:upload --format=php-clover coverage.clover; fi

stages:
  - build
  
jobs:
  fast_finish: true
  include:
    - stage: build
      dist: precise
      php: 5.5
    - stage: build
      dist: precise
      php: 5.6
    - stage: build
      dist: xenial
      php: 7.0
    - stage: build
      dist: xenial
      php: 7.1
    - stage: build
      dist: xenial
      php: 7.2
    - stage: build
      dist: xenial
      php: 7.3
    - stage: build
      dist: bionic
      php: 7.4

@GrahamCampbell
Copy link
Member Author

GrahamCampbell commented Aug 20, 2020

Given that I don't actually use this package, if anyone else wants to finish off this PR, be my guest. Cherry pick my commit, and then commit the rest of the needed changes.

@shehi
Copy link

shehi commented Aug 20, 2020

Neither do I. :) Just trying to see if we could push this through, for Guzzle-7 or not. By the looks of it, things are hopeless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants