Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft OAuth endpoint has changed #146

Closed
bitinn opened this issue Oct 14, 2014 · 3 comments
Closed

Microsoft OAuth endpoint has changed #146

bitinn opened this issue Oct 14, 2014 · 3 comments

Comments

@bitinn
Copy link
Contributor

bitinn commented Oct 14, 2014

It's been in transition for about 2 years, but recently the old endpoint finally starting to return error message (a vague message that doesn't help to debug issue).

The new endpoints are:

https://login.live.com/oauth20_authorize.srf
https://login.live.com/oauth20_token.srf

for authorize and token step respectively, the api for getting user data hasn't changed, but some attribute names have changed.

reference:

  1. http://msdn.microsoft.com/en-us/library/hh243647.aspx
  2. Updating Microsoft OAuth endpoints DotNetOpenAuth/DotNetOpenAuth#236
@oscilate
Copy link

Upvote

@ramsey
Copy link
Contributor

ramsey commented Nov 28, 2014

Please take a look at PR #167. Pull down that branch and test locally. I would like to hear confirmation back that this change fixes the issue and also that Provider\Microsoft::userDetails() gives you back a User object with all the relevant data populated. In particular, I need help testing that email, imageurl, and urls are returned correctly.

Thanks!

ramsey added a commit that referenced this issue Dec 3, 2014
Updating authorize and token URLs for MSFT, according to #146
@ramsey
Copy link
Contributor

ramsey commented Dec 16, 2014

Closing this, as it was confirmed on PR #167 that this works, and I forgot to close the issue.

@ramsey ramsey closed this as completed Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants