Identity Provider: Github enterprise support?

[dbollaer]

Hello,

I was wondering if there is support for github enterpise?
I already tried extending github implementation, overwrite the url's.
But I keep getting the same exception:
Required option not passed: access_token

Mar 11 15:52:10 simplesamlphp ERROR [f1e80aee5a] Backtrace:
Mar 11 15:52:10 simplesamlphp ERROR [f1e80aee5a] 4 /home/oauth-dev/vendor/league/oauth2-client/src/League/OAuth2/Client/Token/AccessToken.php:38 (League\OAuth2\Client\Token\AccessToken::__construct)
Mar 11 15:52:10 simplesamlphp ERROR [f1e80aee5a] 3 /home/oauth-dev/vendor/league/oauth2-client/src/League/OAuth2/Client/Grant/Authorizationcode.php:25 (League\OAuth2\Client\Grant\Authorizationcode::handleResponse)
Mar 11 15:52:10 simplesamlphp ERROR [f1e80aee5a] 2 /home/oauth-dev/vendor/league/oauth2-client/src/League/OAuth2/Client/Provider/IdentityProvider.php:137 (League\OAuth2\Client\Provider\IdentityProvider::getAccessToken)

Thank you in advance.

[TomHAnderson]

This split-question of 1. does this support something it obviously doesn't and 2. why does my code error falls across the liens of 1. No, but you can write it and 2. because you didn't write it right.

I suggest @dbollaer submit a PR with a unit test to show this problem.

[philsturgeon]

The attitude in the reply by Tom is a bit off, but he does make a valid point regardless.

It doesn't support github enterprise out of the box. It probably could with some work though, so fire over a PR to a third  party repo or add some code in. 

Thank you, and sorry.
—
Sent from Mailbox

On Sat, Apr 26, 2014 at 12:11 AM, Tom Anderson notifications@github.com
wrote:

This split-question of 1. does this support something it obviously doesn't and 2. why does my code error falls across the liens of 1. No, but you can write it and 2. because you didn't write it right.

I suggest @dbollaer submit a PR with a unit test to show this problem.

Reply to this email directly or view it on GitHub:
#66 (comment)