Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yandex (russian search engine) provider and user gender support #135

Closed
wants to merge 6 commits into from

Conversation

kudmni
Copy link

@kudmni kudmni commented Sep 12, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.61%) when pulling e128fb8 on kudmni:master into 47d9447 on thephpleague:master.

@ramsey
Copy link
Contributor

ramsey commented Nov 28, 2014

Thank you for your contribution.

This pull request includes too many changes across multiple providers. It is not just adding the Yandex provider. Please see our contributing guidelines, in particular:

  • Create topic branches - Don't ask us to pull from your master branch.
  • One pull request per feature - If you want to do more than one thing, send multiple pull requests.
  • Send coherent history - Make sure each individual commit in your pull request is meaningful. If you had to make multiple intermediate commits while developing, please squash them before submitting.

Furthermore, we're working to pull providers out and make them into their own packages. I've just merged in a new PR that updates the AbstractProvider and provides more details in the README about extending AbstractProvider. Please take a look at the README and consider converting this work into a separate repo for the Yandex provider. Once you've done that, you may send a PR to update the README with a link to your provider.

Thanks!

@ramsey ramsey closed this Nov 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants