Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Uber provider and tests #240

Closed
wants to merge 3 commits into from
Closed

Adding Uber provider and tests #240

wants to merge 3 commits into from

Conversation

stevenmaguire
Copy link
Member

Uber now has an API that utilizes OAuth2. This proposal includes a provider and supporting tests to offer support for Uber.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.17%) to 99.64% when pulling af463cc on stevenmaguire:uber-provider into 7c07e22 on thephpleague:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.82% when pulling 46835e1 on stevenmaguire:uber-provider into 7c07e22 on thephpleague:master.

@ramsey
Copy link
Contributor

ramsey commented Mar 20, 2015

Thank you for your pull request, but please take note of the README section on built-in providers and third-party providers, as well as issue #213.

Our plan for v1.0.0 is to move all providers out of this repository into their own separate repositories, which we can link to from the README or a wiki page.

Please create a separate repo for the Uber provider (use one of the existing linked third-party providers as a model, if you like), and then submit a pull request linking to the Uber provider.

Thanks and sorry for the hassle.

@ramsey ramsey closed this Mar 20, 2015
@stevenmaguire stevenmaguire deleted the uber-provider branch March 21, 2015 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants