Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename user methods to suggest what they do #358

Merged
merged 1 commit into from Jun 29, 2015
Merged

Rename user methods to suggest what they do #358

merged 1 commit into from Jun 29, 2015

Conversation

rtheunissen
Copy link
Contributor

prepareUserDetails -> createUser (protected), creates a UserInterface implementation
getUserDetails -> getUser (public), returns a UserInterface implementation

@rtheunissen
Copy link
Contributor Author

Travis timed out again. 🐌

@ramsey
Copy link
Contributor

ramsey commented Jun 29, 2015

I like these changes. Thanks!

ramsey added a commit that referenced this pull request Jun 29, 2015
@ramsey
Merge pull request #358 from rtheunissen/create_user
cc055f4 
Rename user methods to suggest what they do
@ramsey ramsey merged commit cc055f4 into thephpleague:master Jun 29, 2015
@rtheunissen
Copy link
Contributor Author

I was updating the Reddit provider and found myself staring at prepareUserDetails thinking "wait, what is this method supposed to do exactly?" Naming things is hard. :p

Thanks for the merge. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtheunissen @ramsey