Merge pull request #1349 from Sephster/fix-php-8-test-runner

Fix PHP 8 Test Runner
thephpleague · Jun 6, 2023 · 54674d5 · 54674d5
2 parents 591a631 + a10cde3
commit 54674d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -8,13 +8,21 @@ on:
 
 jobs:
   tests:
-    runs-on: ubuntu-latest
-
     strategy:
       fail-fast: false
       matrix:
-        php: [8.0, 8.1, 8.2]
+        php: [8.1, 8.2]
+        os: [ubuntu-22.04]
         stability: [prefer-lowest, prefer-stable]
+        include:
+          - os: ubuntu-20.04
+            php: 8.0
+            stability: prefer-lowest
+          - os: ubuntu-20.04
+            php: 8.0
+            stability: prefer-stable
+
+    runs-on: ${{ matrix.os }}
 
     name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
 

diff --git a/tests/Utils/CryptKeyTest.php b/tests/Utils/CryptKeyTest.php
@@ -54,9 +54,6 @@ public function testKeyString()
 
     public function testUnsupportedKeyType()
     {
-        if (\str_starts_with(\phpversion(), '8.0')) {
-            $this->markTestSkipped('Cannot generate key on PHP 8.0 runner. Investigating');
-        }
         $this->expectException(\LogicException::class);
         $this->expectExceptionMessage('Unable to read key');