Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaked version constraints #1336

Merged
merged 2 commits into from Apr 3, 2023
Merged

Tweaked version constraints #1336

merged 2 commits into from Apr 3, 2023

Conversation

GrahamCampbell
Copy link
Member

The important change is the PHP version. It is too late to apply an upper-bound in a major release series - composer will just go and get v8.4.1 instead of v8.5.0 which is definitely worse. ;)

@parallels999
Copy link

parallels999 commented Apr 3, 2023

is this for fixing this downgrading?

Package operations: 1 install, 2 updates, 0 removals
  - Installing stella-maris/clock (0.1.7): Extracting archive
  - Downgrading lcobucci/clock (3.0.0 => 2.3.0): Extracting archive
  - Upgrading league/oauth2-server (8.4.1 => 8.5.0): Extracting archive

@Sephster
Copy link
Member

Sephster commented Apr 3, 2023

Thanks Graham. I didn't think of that but makes sense. Will merge soon. Much appreciated 👍

@GrahamCampbell
Copy link
Member Author

@parallels999 No that is not related. Can you run composer why lcobucci/clock please, so we can see why it couldn't install lcobucci/clock 3.0.0?

@parallels999
Copy link

composer why lcobucci/clock
lcobucci/jwt         4.3.0 requires lcobucci/clock (^2.0 || ^3.0)     
league/oauth2-server 8.5.0 requires lcobucci/clock (^2.2.0 || ^3.1.0) 

@GrahamCampbell
Copy link
Member Author

Ohh, it's because lcobucci/clock 3.1.0 requires PHP 8.2. We should probably change the version constraint in this package to allow 3.0 as well as 3.1.

@parallels999
Copy link

You're right, I'm using PHP 8.1, I don't plan on upgrading to 8.2 yet

@GrahamCampbell
Copy link
Member Author

I've adjusted the version constraint down to ^3.0, here.

@Sephster Sephster merged commit f194613 into thephpleague:master Apr 3, 2023
8 checks passed
@Sephster
Copy link
Member

Sephster commented Apr 3, 2023

Thanks @GrahamCampbell

@GrahamCampbell GrahamCampbell deleted the patch-1 branch April 3, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants