-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Roadmap (2017) #146
Comments
Can you give me a to-do list and I will try tackling the changes with one of the gateways that I'm familiar with (either Stripe or PIN or Fat Zebra I guess). |
See the changes in thephpleague/omnipay-mollie#34 and comments in #137 |
OK but what I was hoping for was a step-by-step guide that we can hand off to gateway plugin developers so that they can 3-ify their code. Rather than having to say to them "have a look at some code changes that someone else made and hopefully when you do something similar it will work". Can we wiki that up somewhere? |
Soo, did any get a chance to test the alpha? I used it on a gateway, so as far as I'm concerned, I'm gonna release a beta. |
@barryvdh I tested the alpha and migrated worldpay to it (thephpleague/omnipay-worldpay#29, still waiting to get merged). I am also already migrated Payum OmnipayBridge (Payum/Payum#675), but still waiting for this to get merged (thephpleague/omnipay-dummy#6). But: everything is working fine on my local dev-environment. When are you going to release a beta? Good job 👍 |
@dpfaffenbauer Did you encounter any issues or missed something from how to upgrade? |
In fact, I found your upgrade guide when I was already finished :D It was kinda clear for me on how to change worldpay to make it work. If you take a look at my PR, it's actually very easy to migrate: thephpleague/omnipay-worldpay@87a2d03 |
Yeah I tried to keep it minimal :) I want to release it soonish, only thing I'm not certain about is the HttpClient stuff. Want to get this right and there is a PSR coming for Http Clients (currently in draft), so kind of inclined to wait for that to be accepted. |
I've done a conversion for Sage Pay in this branch: https://github.com/thephpleague/omnipay-sagepay/tree/30alpha1 A few tests I've run to the test API instance seem to work fine. I started this ages ago, and this thread has given me the kick needed to finish it off. I'm not super clear on the dependencies. I assume those will need to be updated as the core 3.0 goes to beta and then production? |
You should be able to set the dependencies to 3.0 already, but lower your minimum stability to test it (to dev or alpha etc) |
Thanks @barryvdh I really need to read up on the way composer does its matching of version numbers, which seems to include some implied regex stuff that I've never got my head around. |
@barryvdh Any thoughts on the It would be nicer if the I guess there are lots of additional properties and features the |
FYI, I want to update it to PSR-18 when accepted, and then release soon: https://groups.google.com/forum/#!topic/php-fig/7PFR-KAAcMk |
Should I be able to try out a 3.x adapter using composer to install? I've not managed to get it to work yet, and cannot work out why. For example, I can clone https://github.com/academe/Omnipay-GiroCheckout master, which is 3.x, install all its dependencies and run some tests (both unit tests in the package, and some external tests to the gateway). That all works fine. However, if I try a Is there a simple composer command that will install ANY 3.x Omnipay adapter, just so I can see it working without thinking that I can be going mad? |
What is this
Has a dependency perhaps simply gone from packagist? |
Okay, it looks like the HTTP client does need to be installed first. This works:
Without installing the guzzle6 adapter (or an equivalent) first, the girocheckout fails to install. Some magical group of necessary packages masquerade as a "virtual" package called Sorry if you already know this stuff. I didn't, so I'm sure others won't either. I think installing from the clone just happened to work because the clone was installing omnipay tests, and the tests install |
Sorry for spamming - I'm going through a learning curve too loudly. Some points and questions though, after sleeping on it:
On the whole though, it's looking good - great work :-) |
Yeah that part is a bit tricky and not sure what the best tradeoff between flexibility and ease-of-use is. The dev version is required for testing indeed, because guzzle adds some useful features there. omnipay/omnipay DOES add a default client (see https://github.com/thephpleague/omnipay/blob/master/composer.json), just not omnipay/common. So libraries etc can just require common, but end-users will get a default client installed (Guzzle), but no gateway should depend on Guzzle ever. I want to use the PSR version instead of Httplug for the interface: https://github.com/php-http/fig-standards/blob/master/proposed/http-client/http-client.md but that's not accepted still.. |
Ah, that's what I read, and probably what I should have installed when testing standalone locally. Makes sense now, thanks. I'll think about what I can add to the docs to explain it. |
Is there any plan to release 3.0 until a specific date? I'd like to use omnipay in a current Symfony version, which is currently unfortunately not possible because of Guzzle. |
I'd like to wait for PSR-18 (HttpClient), but that isn't moving along so fast as I hoped.. |
I've bumped PHP to 7.1 because that is the last supported version (see http://php.net/supported-versions.php ) |
FYI, I've updated the HttpClient, so any implementations using the dev versions should take note: 46daacf Best to require a fixed alpha tag. |
So the first alpha release of the PSR HttpClient is released, so I've included that: As far as I'm concerned, the omnipay-common API shouldn't have to change, we only need to change the underlying HttpClient when it's updated. But the exceptions and usage is the same (unless the spec drastically changes). So if there are no objections, we can tag a beta release and start testing some upgrades. |
Still unwell, still only checking into github periodically but l;et me know if there's anything you need me to do especially on the PayPal or other gateways side. |
So quite a few gateways have been upgraded, according to https://github.com/thephpleague/omnipay#payment-gateways I've removed the dependency on the PSR http-client package, but mimic it's behavior. I think we can just use that. Did any of you encounter any problems? If not, I think we're good to go for stable. |
It's tagged. Not all gateways yet, but upgrade guide is here: https://omnipay.thephpleague.com/changelog/ |
Main goals
omnipay/omnipay
omnipay/common
Tests
Gateways
The text was updated successfully, but these errors were encountered: