Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require latest PHPUnit, upgrade test suite to PHPUnit 9.5+ semantics #23

Merged
merged 5 commits into from Jun 3, 2021
Merged

Require latest PHPUnit, upgrade test suite to PHPUnit 9.5+ semantics #23

merged 5 commits into from Jun 3, 2021

Conversation

Ocramius
Copy link
Contributor

@Ocramius Ocramius commented Jun 3, 2021

No description provided.

@Ocramius
Copy link
Contributor Author

Ocramius commented Jun 3, 2021

Build seems to fail because of an old PHP_CodeSniffer version: https://travis-ci.org/github/thephpleague/omnipay-rabobank/jobs/773395448

Will see if an upgrade is possible.

@Ocramius
Force installation of latest squizlabs/php_codesniffer, compatible …
dbb3471 
…with PHP 7.3+
@Ocramius
Enforce a php-http/client-implementation to exist when updating dep…
7066813 
…endencies

Without a `php-http/client-implementation`, no HTTP
client can be found, and therefore we get runtime
test failures.
@Ocramius
Enforce a php-http/client-implementation to exist when updating dep…
7393080 
…endencies

Without a `php-http/client-implementation`, no HTTP
client can be found, and therefore we get runtime
test failures.
@Ocramius
Requiring a PSR response factory
e6aba42
@Ocramius
Copy link
Contributor Author

Ocramius commented Jun 3, 2021

@barryvdh managed to get it green - a bit annoying to add all these require-dev, so perhaps in future I suggest running off a composer.lock for builds, and letting dependabot bump things regularly, but overall this brings us to PHP 7.3, 7.4 and 8.0 parity 👍

@barryvdh barryvdh merged commit f680a69 into thephpleague:master Jun 3, 2021
@barryvdh
Copy link
Member

barryvdh commented Jun 3, 2021

Not really sure why phpunit and the http clients are required, most should be provided by the omnipay/tests package. But will take look, thanks!

@Ocramius Ocramius deleted the feature/php-8-readiness branch June 3, 2021 16:07
@Ocramius
Copy link
Contributor Author

Ocramius commented Jun 3, 2021

Yeah, they only get dropped by --prefer-lowest upgrades, so I think there's a bug in the dependency graph somewhere. My additions are just here to "bump" the lower end, but overall reducing supported ranges would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ocramius @barryvdh