Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require correct PHP version on composer #118

Merged

Conversation

ricardofiorani
Copy link
Contributor

Since omnipay/common requires PHP 5 and this package doesn't require any PHP version BUT works only with PHP 7.1+, then it should have the right PHP version to be required in order to avoid this package being required in the wrong php environment.

@judgej
Copy link
Member

judgej commented Oct 25, 2018

The tests work down to PHP 5.6, so it certainly is compatible with PHP 5.6 at least. I'm going to try to keep compatibility with 5.6 while Omnipay Common does, probably another 6-9 months.

Is it the documentation that says 7.1?

@ricardofiorani
Copy link
Contributor Author

ricardofiorani commented Oct 25, 2018

@judgej on the readme it says:

This version only supports PHP 7.1+.

EDIT: @judgej I'll update it to match omnipay/common 's composer requirements and the documentation as well then.

@judgej
Copy link
Member

judgej commented Oct 25, 2018

Okay, it's probably the readme that is wrong. It did only support 7.1 at one point, but the 7.1+ syntax was so little used, that was changed.

@judgej judgej merged commit 691905d into thephpleague:master Oct 25, 2018
@jamieburchell
Copy link
Contributor

jamieburchell commented Jan 18, 2022

@judgej This change causes a composer "downgrade" to version 3.2.0 from >3.2.0 on PHP 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants