Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Create plan request #185

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Conversation

AntoineLemaire
Copy link
Contributor

@AntoineLemaire AntoineLemaire commented Jun 28, 2020

Deprecated:

name and statement_descriptor does not exist anymore in Stripe API.

  • setName() replaced by setNickName()
  • getName() replaced by getNickName()
  • setStatementDescriptor()
  • getStatementDescriptor()
{
  "error": {
    "code": "parameter_unknown",
    "doc_url": "https://stripe.com/docs/error-codes/parameter-unknown",
    "message": "Received unknown parameters: name, statement_descriptor",
    "param": "name",
    "type": "invalid_request_error"
  }
}

@barryvdh
Copy link
Member

So is this a breaking change, or was it broken now?

@AntoineLemaire
Copy link
Contributor Author

@barryvdh It's not working, you'll have a $response->isSuccessful() === false each time if you use any of name or statement_descriptor. But not any Exception will be thrown

As I removed fonctions, it's BC yes.

Should I put them back with a deprecated, and not use them in getData() function?

@barryvdh
Copy link
Member

Maybe we can deprecate both and remove them from the getData perhaps.

@AntoineLemaire
Copy link
Contributor Author

@barryvdh Done ;)

@barryvdh barryvdh merged commit 2c7cc0a into thephpleague:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants