Fix: Do not encourage to edit composer.json #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this, editing Composer was the only way to do it before, and this is a remnant from those days. I'm thinking all we need is this though: If you want to update, cool, otherwise I can! |
|
Hang on a second! |
localheinz
force-pushed
the
fix/composer
branch
from
f972eba
to
a9ce58e
Compare
ragboyjr
reviewed
Dec 23, 2016
| } | ||
| } | ||
| ``` | ||
| $ composer require league/plates | ||
| ``` |
There was a problem hiding this comment.
Looks great, @reinink do you want the $ or not? I just scanned various php league packages and some have the $ and some don't.
There was a problem hiding this comment.
Probably not, but we can remove that post merge.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
README.mdand suggests to requireleague/platesvia command line, rather than editingcomposer.jsondirectly