Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use all the columns #88

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

This PR

  • uses all the columns when showing the progress of running the tests

Before

$ vendor/bin/phpunit
PHPUnit 4.8.6 by Sebastian Bergmann and contributors.

...............................................................  63 / 130 ( 48%)
.....................................................R..RR..... 126 / 130 ( 96%)
R...

Time: 2.18 seconds, Memory: 12.75Mb

OK, but incomplete, skipped, or risky tests!
Tests: 130, Assertions: 203, Risky: 4.

Generating code coverage report in Clover XML format ... done

Generating code coverage report in HTML format ... done

After

$ vendor/bin/phpunit
PHPUnit 4.8.6 by Sebastian Bergmann and contributors.

....................................................................................................................R..RR.....R...

Time: 2.28 seconds, Memory: 12.75Mb

OK, but incomplete, skipped, or risky tests!
Tests: 130, Assertions: 203, Risky: 4.

Generating code coverage report in Clover XML format ... done

Generating code coverage report in HTML format ... done

@frankdejonge
Copy link
Member

@localheinz I'm not really seeing the advantage here, care to enlighten me?

@localheinz
Copy link
Contributor Author

@frankdejonge

Ha, sure, - using max columns spreads the progress across the whole width of your screen!

@frankdejonge
Copy link
Member

@localheinz which is better because ....? ~.^

@localheinz
Copy link
Contributor Author

@frankdejonge

Because we've all got big screens, right? 🤓

@frankdejonge
Copy link
Member

I personally like that each line also gives an indication to how far along the entire suite is because of the X of Y (12/340) indicator. But in the end it's up to @reinink :neckbeard:

@localheinz
Copy link
Contributor Author

@frankdejonge @reinink

👍

@reinink
Copy link
Contributor

reinink commented Dec 11, 2015

Well, I'd rather just stick to what most of the League is doing here. I mean no disrespect to @localheinz, but if no one else is doing this, I probably won't either.

@localheinz
Copy link
Contributor Author

@frankdejonge

It will still wrap, of course, on small screens.

It's probably more useful for a package or application where you have thousands of tests.

@reinink
Copy link
Contributor

reinink commented Dec 11, 2015

@localheinz That makes sense. Going to close this one.

@reinink reinink closed this Dec 11, 2015
@localheinz localheinz deleted the fix/columns branch December 11, 2015 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants