Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Return early #94

Merged
merged 2 commits into from
Dec 11, 2015
Merged

Fix: Return early #94

merged 2 commits into from
Dec 11, 2015

Conversation

localheinz
Copy link
Contributor

This PR

  • throws the exception early, so we don't need an else here
  • returns early, so we don't need an else here
  • removes elses where we're returning early already

馃拋 It's all covered by tests, no?!

@localheinz localheinz changed the title Fix: Throw the exception already Fix: Return early Aug 30, 2015
reinink added a commit that referenced this pull request Dec 11, 2015
@reinink
Merge pull request #94 from localheinz/fix/else
ddc16a5 
Fix: Return early
@reinink reinink merged commit ddc16a5 into thephpleague:master Dec 11, 2015
@reinink
Copy link
Contributor

reinink commented Dec 11, 2015

Nice finds! Thanks. 馃憤

@localheinz localheinz deleted the fix/else branch December 11, 2015 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@localheinz @reinink