Make Router a RequestHandlerInterface #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipobenito
requested changes
Feb 20, 2020
src/Router.php
Outdated
| * @param ServerRequestInterface $request | ||
| * @return ResponseInterface | ||
| */ | ||
| public function handle(ServerRequestInterface $request): ResponseInterface |
There was a problem hiding this comment.
I'd want this the other way round, handle to proxy to dispatch and won't be deprecating the dispatch method, router/dispatcher first with ability to run as a middleware second
src/Router.php
Outdated
|
|
||
|
|
||
| /** | ||
| * @param ServerRequestInterface $request |
There was a problem hiding this comment.
I will fix this today for you so you can get your release out!
philipobenito
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #269