Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 5.x #283

Closed
wants to merge 13 commits into from
Closed

Initial 5.x #283

wants to merge 13 commits into from

Conversation

philipobenito
Copy link
Member

Here are the initial 5.x changes.

TODO:

  • Add 5.x documentation
  • Refactor and add more unit tests

Input welcome.

@memran
Copy link

memran commented Jun 24, 2020

My little inputs are here:

  1. Subdomain Routing [it will help for SaaS application]
  2. Fallback Routing [user may define a callable route that will be executed when no other route matches the incoming request.]
  3. Route Name [ set and get method]
  4. Route Group Name [ set and get method]
  5. Load Routes initially and Dispatch later to support like swoolephp or reactphp http server

@philipobenito
Copy link
Member Author

@memran most of that is either existing functionality or is covered in this PR, the only thing that isn't specifically there is your second point, because it's not really recommended, and should be handled by creating a custom strategy with a handler for not found routes.

@memran
Copy link

memran commented Jun 24, 2020

@memran most of that is either existing functionality or is covered in this PR, the only thing that isn't specifically there is your second point, because it's not really recommended, and should be handled by creating a custom strategy with a handler for not found routes.

Right. I am using custom strategy with middleware. it will be easier to have option as route declarative.Though it is optional.

@TMschar
Copy link

TMschar commented Oct 10, 2020

Hey! What is the status of this PR? Anyway I can help? Whats the plan for 7.4 support / upcoming 8 support?

@philipobenito
Copy link
Member Author

@SimZor I was aiming for a release last week but I've had flu so now aiming for some point in the next two weeks.

The main thing that would be helpful for anyone that wants to help would be to extensively test the cached router implementation, try to break it and tell me how you broke it.

@github-pages github-pages bot temporarily deployed to github-pages January 25, 2021 13:50 Inactive
@philipobenito philipobenito deleted the branch master January 25, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants