Fix wrong setup for Symfony 3.3 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix, I'm not comfortable with the DI test helpers. |
|
Thanks for your PR, I switched my handlers to private, it made my day \o/ |
tyx
commented
May 30, 2017
| @@ -36,7 +35,7 @@ public function testHandleCommandWithInvalidMiddleware() | |||
| commandbus: | |||
| default: | |||
| middleware: | |||
| - tactician.middleware.validator | |||
| - tactician.middleware.whatever | |||
There was a problem hiding this comment.
to not be redundant with the test in ValidatorTest
tyx
commented
May 30, 2017
| $this->registerHandlerServiceLocator($container, $locatorServiceId, $handlerMapping); | ||
| $locatorDefinition = $this->buildLocatorDefinition($handlerMapping, 'tactician.commandbus.'.$busId.'.handler.service_locator', ContainerLocator::class); | ||
| $this->registerHandlerServiceLocator($container, 'tactician.commandbus.'.$busId.'.handler.service_locator', $handlerMapping); | ||
| $locatorDefinition = $this->buildLocatorDefinition($handlerMapping, ContainerLocator::class, 'tactician.commandbus.'.$busId.'.handler.service_locator'); |
There was a problem hiding this comment.
I guess the new serviceId variable deserves a variable to make reading easier
tyx
force-pushed
the
fix/wrong-arguments-order
branch
from
4f588b9
to
a675dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the #45
Sorry for the CS fix, I was too hurry to move them in a dedicated commit.