Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Limit range of accepted PHP versions #102

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

This PR

  • limits the range of accepted PHP versions

馃拋 We can't tell for sure yet whether this package will be compatible with PHP 9000, can we?

@localheinz
Copy link
Contributor Author

@rosstuck

While we're at it, maybe worth dropping support for PHP 5.5?

@GrahamCampbell
Copy link
Member

The league's policy is not to drop for no reason.

@GrahamCampbell
Copy link
Member

If there are some PHP 5.6 features that we want to actually use, that's when 5.5 would be dropped.

@rosstuck
Copy link
Member

@localheinz Thanks but at this time, I'm okay with waiting to see what future versions will bring before limiting it to an upper bound. Tactician is relatively small and with PHP's general BC policy, I think we'll be okay with adding it to the test matrix when the time comes. With regards to 5.5, it's officially EOL. I may deprecate at a future point (2.0, if there's ever a need).

@GrahamCampbell I'm aware of League policy, it's a decision I'll make when relevant.

@rosstuck rosstuck closed this Jul 23, 2016
@localheinz localheinz deleted the fix/php9000 branch July 23, 2016 19:10
@frankdejonge
Copy link
Member

@rosstuck while it's common to do so, I don't believe there's actually a policy to prevent the deprecation of PHP version support. /cc @GrahamCampbell

@GrahamCampbell
Copy link
Member

Phil mentioned it a few months ago. Sorry I can't remember where. It was basically along the lines of don't do it for the sake of doing it. As in, there is no policy to force bump the league packages.

@frankdejonge
Copy link
Member

True, but that's an opinion, not a policy. I think a pretty good case can be made to up when a version is not supported anymore, if only to change/upgrade gradually without a massive jump from say 5.3 to 7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants