Drop EOLed PHP versions #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aww yiss!
In all seriousness, I'm on vacation right now so this will have to wait 10
days or so, sorry. I'm very inclined to drop 7.0 support, may drop 7.1
support in next major version so we can get that sweet sweet object
typehint finally. :)
Thanks for the nudge on this!
…On Sat, Dec 1, 2018, 2:48 AM Šimon Podlipský ***@***.*** wrote:
I saw this on github
[image: image]
<https://user-images.githubusercontent.com/327717/49305652-1a837d80-f4d0-11e8-91cd-986606ad0eb3.png>
so I was like, yea, let's do this! Let's use modern standards!
PHP 7.1 support is gone when you wake up this morning
<http://php.net/supported-versions.php>
[image: image]
<https://user-images.githubusercontent.com/327717/49305695-3b4bd300-f4d0-11e8-8380-a4c159936663.png>
It's been great ride but it's time to say goodbye.
Let's use all those new features PHP has to offer and don't get stuck on
PHP legacy versions.
------------------------------
You can view, comment on, or merge this pull request online at:
#127
Commit Summary
- Drop EOLed PHP versions
File Changes
- *M* .travis.yml
<https://github.com/thephpleague/tactician/pull/127/files#diff-0> (14)
- *M* composer.json
<https://github.com/thephpleague/tactician/pull/127/files#diff-1> (2)
Patch Links:
- https://github.com/thephpleague/tactician/pull/127.patch
- https://github.com/thephpleague/tactician/pull/127.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#127>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI9ThLgTlBfuaEMY0AjTcSYrFmWd3nMks5u0W9QgaJpZM4Y8HGW>
.
|
|
Just a quick update, I'm likely going to go through and review all the Tactician packages and update them accordingly. That'll be a bigger effort (since I want to change typehints, interfaces, etc) so this'll happen but when I have a bit more time to sink into everything at once. :) |
|
Happening now in master :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this on github
so I was like, yea, let's do this! Let's use modern standards!
PHP 7.1 support is gone when you wake up this morning
It's been great ride but it's time to say goodbye.
Let's use all those new features PHP has to offer and don't get stuck on PHP legacy versions.