Skip to content
This repository has been archived by the owner. It is now read-only.

[3.x] Fix multibyte encoding #79

Merged
merged 1 commit into from Jun 30, 2015
Merged

[3.x] Fix multibyte encoding #79

merged 1 commit into from Jun 30, 2015

Conversation

@mlocati
Copy link
Contributor

mlocati commented Jun 30, 2015

移設 gets converted to ~%A7%BB%E8%A8%AD, but should be %E7%A7%BB%E8%A8%AD

移設 gets converted to ~%A7%BB%E8%A8%AD, but should be %E7%A7%BB%E8%A8%AD
@mlocati mlocati changed the title Fix multibyte encoding [3.x] Fix multibyte encoding Jun 30, 2015
nyamsprod added a commit that referenced this pull request Jun 30, 2015
[3.x] Fix multibyte encoding
@nyamsprod nyamsprod merged commit 66a9e42 into thephpleague:3.x Jun 30, 2015
1 of 2 checks passed
1 of 2 checks passed
Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mlocati
Copy link
Contributor Author

mlocati commented Jun 30, 2015

Thank you! Any ETA for a new 3.x release?

@mlocati mlocati deleted the mlocati:3.x-fix-multibyte-query branch Jun 30, 2015
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jun 30, 2015

The last 3.x tag says there will be no more 3.x releases.

@mlocati
Copy link
Contributor Author

mlocati commented Jun 30, 2015

Is it safe to use composer require league/url:3.x-dev? I mean, do you plan to remove the 3.x-dev branch in the future?

@nyamsprod
Copy link
Member

nyamsprod commented Jun 30, 2015

No I won't remove the branch I have no reason to do so

@mlocati
Copy link
Contributor Author

mlocati commented Jun 30, 2015

Thank you!

@GrahamCampbell
Copy link
Member

GrahamCampbell commented Jun 30, 2015

Is it safe to use composer require league/url:3.x-dev

You should use a proper version constraint.

@mlocati
Copy link
Contributor Author

mlocati commented Jun 30, 2015

You should use a proper version constraint.

Thank you @GrahamCampbell, but I don't understand what you mean...
Do you mean that we should use a specific release of this component? If so, the problem is that league/url won't have any new 3.x release, but we need this fix...

@nyamsprod
Copy link
Member

nyamsprod commented Jun 30, 2015

@mlocati @GrahamCampbell the fix is indeed important. So releasing a 3.3.4 can still be possible since 4.0.0 release was postponed. But as soon as 4.0 is out no more 3.x will be release there's no LTS on league\url 3.0. I would strongly suggest starting using or testing 4.0 as this version will soon be release and offer a much better API/Experience. I maybe repeating myself but I insist the only reason your PR was accepted and a 3.3.4 is possible is because 4.0.0 is not yet out.

@mlocati
Copy link
Contributor Author

mlocati commented Jun 30, 2015

Great news @nyamsprod
BTW, we can't upgrade to 4.0 since concrete5 still supports php 5.3...

@nyamsprod
Copy link
Member

nyamsprod commented Jul 1, 2015

league\url 3.3.4 is out

@mlocati
Copy link
Contributor Author

mlocati commented Jul 1, 2015

league\url 3.3.4 is out

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.