new class to house the blade filters #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use forward_static_call instead
SeanJA
force-pushed
the
use-custom-class-instead
branch
from
4e3de20
to
3cd3d06
Compare
|
@SeanJA Thanks for the PR, let's hope it gets accepted and merged. I see good use of this package, but am a little taken aback based on @iamgergo initial response to your issue. Heck, besides that, the package took on some unnecessary heat when posted by Laravel News, folks just need to chill out. If they don't have a use for it, don't use it. If they think using pure PHP functions is the way to go, then dont use it. |
|
@mikeerickson Right? It's not like this package is being forced on them... I wonder if that added to the defensiveness? 🤔 |
|
I have used Twig and Django quite a bit, just as well using Vue or Angular, so I can see the benefit to using this type of package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passes things on to Str if it cannot find a macro defined
throw an exception if there isn't a filter found
updated docs
updated coverage entry in phpunit.xml