[WIP] Build with meson #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also get it compiling with VS2017
|
You'll also notice that the git versions will update every build, as opposed to every run of CMake, like in #88 (aiui). How it's written right now is also quite fast - it only requires rebuilding the one file, not every single file where the defines have changed. |
I'm probably not going to do the downloading and building of rustc unless @thepowersgang gives the go-ahead, but here's how it might start to look
|
Could you separate the source changes out from the new build system? |
|
Sure, I just wanted to make sure it built. |
|
I'm closing this PR in favour of using CMake (sorry). |
|
np! I'll see if I can do the thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I'm a VS2017 user, I also made sure to get it compiling with VS2017.
This is just an initial pass. I think it's a useful comparison with #88, as I think meson is far simpler and easy to read compared to CMake.