Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't play video on google pixel #86

Closed
jessleenyc opened this issue Jun 12, 2020 · 2 comments · Fixed by #90
Closed

Can't play video on google pixel #86

jessleenyc opened this issue Jun 12, 2020 · 2 comments · Fixed by #90
Assignees
Labels
bug bugs; wait for 'approved' label to begin work

Comments

@jessleenyc
Copy link
Contributor

Describe the bug

To Reproduce

  1. Visit https://dev.to/bytesized/byte-sized-episode-1-grace-hopper-3bp9
  2. Try to play video
  3. See error

Screenshots

Screenshot_20200611-162518

Smartphone (please complete the following information):

  • Device: Google Pixel 3
  • OS: Android 10
@fdocr fdocr added the bug bugs; wait for 'approved' label to begin work label Jun 12, 2020
@fdocr
Copy link
Contributor

fdocr commented Jun 12, 2020

Android's WebView implementation has problems reproducing Video from the HTML video tag. There doesn't seem to be a straightforward fix for this at the moment using "stock configuration" options from the WebView itself.

Possible solutions I can think of:

  1. Customize our CustomWebViewClient to handle pages that have the HTML video tag and handle the playback in a separate view with a separate native Fragment/Activity. I found this project (older and now unmaintained) that took a stab at this, might be valuable to take inspiration from it
  2. Use the AndroidWebViewBridge interface to stop the HTML video tag from attempting to play the video and instead handle an incoming message from JavaScript that will trigger the video playback using native APIs

At the moment option 2. seems like a better solution in my eyes.

In either case it's important to consider we already have ExoPlayer in the project so we could relatively easy handle the video playback using their PlayerView

@maestromac
Copy link
Contributor

@fdoxyz Yeah option 2 sounds good.

@fdocr fdocr self-assigned this Jun 22, 2020
@fdocr fdocr closed this as completed in #90 Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs; wait for 'approved' label to begin work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants