Native video streaming support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maestromac
approved these changes
Jul 2, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR intends to override the HTML video tag problem from the WebViewClient. It uses the ExoPlayer PlayerView to stream the video in a separate Activity natively.
While working on it I started tweaking the directory, one thing led to another and ended up refactoring the project directory (following most of the ideas shared in #87).
In order to make this work an event must come from JavaScript. This is not implemented yet (PR to web repo coming soon). This can be tested by executing the following in Chrome's Developer Tools in order to have the video player pop-up manually:
Related Tickets & Documents
Fixes #86
Cleans up the directory a bit for #87
Screenshots/Recordings (if there are UI changes)
Might take a minute for the GIF to load:
[optional] What gif best describes this PR or how it makes you feel?