Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover the button on sidebar #1672

Closed
thomasbnt opened this issue Jan 28, 2019 · 6 comments
Closed

Hover the button on sidebar #1672

thomasbnt opened this issue Jan 28, 2019 · 6 comments
Labels
bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.

Comments

@thomasbnt
Copy link
Contributor

Describe the bug
The hover of the button in the sidebar is a little under pressure .

Link to the post of example

To Reproduce
Hover the button.

Expected behavior
No bug with the focus and hover.

Screenshots
bug_css_devto_28012019

Desktop (please complete the following information):

  • OS: Ubuntu 16.04
  • Browser : Chrome
  • Version : Version 71.0.3578.98 (Official Build) (64 bits)
@rhymes
Copy link
Contributor

rhymes commented Jan 28, 2019

info for who might take this one: doesn't happen on Firefox 65 in macOS

button

@Link2Twenty
Copy link
Contributor

Link2Twenty commented Jan 29, 2019

As a general rule animating margin and padding is a bad idea.

@rhymes I think it might actually be the screen resolution that's making the difference.

This code is causing the problem.
https://github.com/thepracticaldev/dev.to/blob/9ea53d5669ce17b105aa5adc39f4a6871bdafd3a/app/assets/stylesheets/sticky-nav.scss#L167-L189

I would propose this change

a.primary-sticky-nav-org-cta-link{
  display: inline-block;
  font-size:1.25em;
  border:0px;
  border-radius:100px;
  padding: 6px 38px;
  margin-top: 20px;
  background: white;
  color: $black;
  font-family: $helvetica-condensed;
  font-weight: bold;
  text-align: center;
  font-stretch: condensed;
  box-shadow: $light-shadow;
  margin-bottom: 5px;
  transform: scale(0.99) translateY(0px);
  transition: transform 150ms cubic-bezier(0.4, 0.0, 0.2, 1);
  &:hover {
    box-shadow: $dark-shadow;
    transform: scale(1) translateY(-1px);
  }
}

animate_contrib

@thomasbnt
Copy link
Contributor Author

Very nice @Link2Twenty 👍

@jessleenyc jessleenyc added bug always open for contribution external contributors welcome contribution is welcome! labels Jan 29, 2019
@maestromac maestromac added the good first issue good first issues for anyone new to programming and new to the project. label Apr 25, 2019
@shraddhaag
Copy link

Hi! I would like to take this up :)

@webdevike
Copy link

I just checked this bug on chrome and it seems to be working. Has this been resolved?

@maestromac
Copy link
Member

maestromac commented Jun 6, 2019

Thanks for pointing that out @ikey2244 . I can't reproduce it either on Chrome or on Firefox.

Assume resolved. Please let us know if otherwise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

No branches or pull requests

7 participants