Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(Night Mode): Embedded comments are hard to read #2221

Closed
healeycodes opened this issue Mar 26, 2019 · 3 comments
Closed

Bug(Night Mode): Embedded comments are hard to read #2221

healeycodes opened this issue Mar 26, 2019 · 3 comments
Labels
bug always open for contribution external contributors welcome contribution is welcome!

Comments

@healeycodes
Copy link

Describe the bug
With Night Mode enabled, embedded comments in articles are hard to read.

They show up as black text against a dark blue background.

To Reproduce
With Night Mode enabled, go to an article that embeds comments.

Such as https://dev.to/devteam/top-5-dev-comments-from-the-past-week-gia

Screenshots

An embedded comment

Desktop:

  • OS: Windows 10 OS Build 17134.648
  • Browser: Chrome
  • Version: 73.0.3683.86 (Official Build) (64-bit) (cohort: Stable)
@jessleenyc jessleenyc added bug always open for contribution external contributors welcome contribution is welcome! labels Mar 26, 2019
@theNaut1lus
Copy link
Contributor

I am able to reproduce this issue on both Safari and Firefox.

@healeycodes @jessleenyc I would like to take up this issue and work on it

@healeycodes
Copy link
Author

Feel free @co16353sidak! I claim no ownership 😄

@theNaut1lus
Copy link
Contributor

theNaut1lus commented Mar 31, 2019

I have implemented some designs which I think should be sufficient for the embedded code blocks.
Screenshot 2019-03-31 at 1 51 46 PM

Following the style followed in the default mode, I made the changes accordingly in the night mode as:

Screenshot 2019-03-31 at 1 51 39 PM

Would love it if someone had a look at this first before I submit a PR for the same.
@jessleenyc @benhalpern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

4 participants