Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Changes clear link is too close to Save Changes and doesn't pick up on Ctrl+Z. #5763

Closed
AleksandrHovhannisyan opened this issue Jan 27, 2020 · 1 comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc.

Comments

@AleksandrHovhannisyan
Copy link

Describe the bug

There are two related issues:

  1. The New Changes (clear) text is too close to the Save Changes button, and is also too small on desktop.

  2. If you undo changes with Ctrl+Z, the draft still thinks there are unsaved changes.

image

To Reproduce

  1. Create a post.

  2. Click Edit to edit the post.

  3. Make changes to the post's contents. Observe that the New Changes (clear) link appears above the blue Save Changes button, and that it's too close.

  4. Undo all of your changes with Ctrl+Z. Observe that New Changes (clear) still remains.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 79

Proposed solution

What about introducing a separate inline button, Cancel, that just backs out of the editor and discards all changes?

@rhymes rhymes added area: publishing experience issues related to an authors experience publishing. Tags, series, etc. tech: fullstack labels Jan 27, 2020
@cmgorton
Copy link
Contributor

The layout for this appears to have changed. I don't think this is an issue anymore. I am going to close this but let me know if it is and I will reopen this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc.
Projects
None yet
Development

No branches or pull requests

4 participants